serial_port: refactoring serial read to use readyRead signal#37
Merged
Conversation
4d98036 to
cba8bdd
Compare
jciberlin
approved these changes
Apr 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is replacing Qt
waitForReadyReadwith newWaitForReadyReadfunction that relay onreadReadsignal.The new functionality is using a buffer for collecting data. Once
WaitForReadyReadexits, buffered data can be copied, after what will be cleared and ready for new usage.Benefits:
waitForReadyReadfor Windows where functions wait the full timeout time, which causes a bad user experience.